Yes, you will still need to apply for a National Insurance Number if you have a British passport. Your British passport can simplify the process of settling in the UK, but you will still need to go through the application process as you will have not been automatically enrolled, despite your dual citizenship.